SP983c Basel IV amplifier remote control #2707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2707 +/- ##
==========================================
- Coverage 65.36% 65.31% -0.06%
==========================================
Files 207 208 +1
Lines 27978 28021 +43
==========================================
+ Hits 18288 18302 +14
- Misses 9690 9719 +29 |
|
thanks @ThorvaldLarsen for the PR! apart from what you mentioned, we should also look into adding the remote control capability as an option to the existing basel preamp driver, or, at least, make sure the set of parameters are exactly the same between the "virtual" and remote-controlled driver. |
…l input_offset_voltage
jenshnielsen
changed the title
FarBo
requested review from
Akshita07,
jenshnielsen and
astafan8
and removed request for
jenshnielsen
astafan8
reviewed
Apr 8, 2021
|
@Akshita07 |
|
@FarBo Yes, I'll address them tomorrow. Thanks Farzad. |
Co-authored-by: Mikhail Astafev <astafan8@gmail.com>
astafan8
approved these changes
Apr 9, 2021
FarBo
approved these changes
Apr 9, 2021
docs/examples/driver_examples/Qcodes example with Basel SP983c Preamp.ipynb
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a driver for the Basel SP983 amplifier for remote control. The string interaction is somewhat weird for the driver but even so the current commands can likely be written in a cleaner way.
If an error occurs the instrument can get stuck in a loop if an error occurs where one has to ping the instrument multiple times to clear the error message from the VISA log. Would be good to discuss with a developer the best way to handle this case. Driver documentation is sparse but can be found here: link.
Need to retest driver from the branch.