tests: cleanup warning handling #2834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2834 +/- ##
=======================================
Coverage 65.32% 65.32%
=======================================
Files 209 209
Lines 28210 28210
=======================================
Hits 18429 18429
Misses 9781 9781 |
astafan8
reviewed
Mar 19, 2021
|
@jenshnielsen Should we try to land this before 0.26.0 release? I can take a look at the errors for python 3.9 |
|
@trevormorgan We could at least land the improvements to the tests to use the correct context managers. I think there is a test within the monitor module that needs significant work on all versions of python so it may take some time to get all warnings enabled |
jenshnielsen
force-pushed
the
error_on_warnings
branch
from
300f3f7
to
dc7227b
Compare
jenshnielsen
force-pushed
the
error_on_warnings
branch
from
dc7227b
to
51bc046
Compare
|
@trevormorgan and @astafan8 Retargeted this to just cleanup some warning handling in tests so this should be ready to land now |
astafan8
approved these changes
May 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should eventually help us get to a point where warnings can become errors for testing