fix(logger): Disable conditionally start logging for Sphinx documenta… #2909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion. Solves #2908 - Swapped `start_logging_on_import` and `running_in_test_or_tool` so that the tools are evaluated before starting logging on import. - Added sphinx main to the list of tools.
Codecov Report
@@ Coverage Diff @@
## master #2909 +/- ##
==========================================
- Coverage 65.31% 65.30% -0.01%
==========================================
Files 208 208
Lines 28021 28021
==========================================
- Hits 18302 18300 -2
- Misses 9719 9721 +2 |
jenshnielsen
approved these changes
Apr 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable conditionally start logging for Sphinx documentation. Solves #2908
Fixes #2908.
Changes proposed in this pull request:
start_logging_on_importandrunning_in_test_or_toolso that the tools are evaluated before starting logging on import.Edit This is not really a proper fix for the issue that seems to be lying elsewhere but a work around that should enable users to build documentation in certain configurations.