plot_dataset avoid loading from db if in cache #2918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astafan8
previously approved these changes
Apr 12, 2021
jenshnielsen
commented
Apr 12, 2021
Since: * These rely on implicit order of the lists which is not guaranteed * They are testing logic that has nothing really to do with the module under test
return all data if dependent parameters is empty
jenshnielsen
force-pushed
the
load_from_cache_in_plot
branch
from
68907d2
to
f510520
Compare
|
Two issues were discovered.
|
jenshnielsen
dismissed
astafan8’s stale review
Significant changes since review
Codecov Report
@@ Coverage Diff @@
## master #2918 +/- ##
==========================================
- Coverage 65.30% 65.30% -0.01%
==========================================
Files 208 208
Lines 28021 28025 +4
==========================================
+ Hits 18300 18302 +2
- Misses 9721 9723 +2 |
This reverts commit f510520.
astafan8
approved these changes
Apr 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should both provide a speed boost for plotting data live and and make plot_dataset work for data not stored in the db