-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
contribution guidelines: remove no longer relevant sections and make the sections on naming somewhat less strict #2937
contribution guidelines: remove no longer relevant sections and make the sections on naming somewhat less strict #2937
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2937 +/- ##
=======================================
Coverage 65.31% 65.31%
=======================================
Files 209 209
Lines 28037 28037
=======================================
Hits 18312 18312
Misses 9725 9725 |
This looks great, thanks for simplifying! I would also perhaps add a section on how to write tests using mock instruments. |
Agreed (my reference to pyvisa-sim was intended to cover something similar) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that for now this is a good cleanup.
Shall the PR be renamed to "contribution guidelines: remove no longer relevant sections and make the sections on naming somewhat less strict" ? :)
Co-authored-by: Mikhail Astafev <astafan8@gmail.com>
Start updating the contribution guide.
Remove no longer relevant sections and make the sections on naming somewhat less strict:
There is a lot more updating that could be done. Specifically I think we should perhaps write something about pyvisa-sim and example notebooks (or at least add some links)
@astafan8 @trevormorgan @samantha-ho @sohailc @FarBo @Akshita07 @Dominik-Vogel
Please have a look and see if there is anything you would like to change