Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contribution guidelines: remove no longer relevant sections and make the sections on naming somewhat less strict #2937

Merged
merged 14 commits into from
Apr 21, 2021

Conversation

jenshnielsen
Copy link
Collaborator

@jenshnielsen jenshnielsen commented Apr 16, 2021

Start updating the contribution guide.
Remove no longer relevant sections and make the sections on naming somewhat less strict:

There is a lot more updating that could be done. Specifically I think we should perhaps write something about pyvisa-sim and example notebooks (or at least add some links)

@astafan8 @trevormorgan @samantha-ho @sohailc @FarBo @Akshita07 @Dominik-Vogel
Please have a look and see if there is anything you would like to change

@codecov
Copy link

codecov bot commented Apr 16, 2021

Codecov Report

Merging #2937 (ac6df18) into master (f994d69) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2937   +/-   ##
=======================================
  Coverage   65.31%   65.31%           
=======================================
  Files         209      209           
  Lines       28037    28037           
=======================================
  Hits        18312    18312           
  Misses       9725     9725           

@guenp
Copy link
Contributor

guenp commented Apr 16, 2021

This looks great, thanks for simplifying! I would also perhaps add a section on how to write tests using mock instruments.

@jenshnielsen
Copy link
Collaborator Author

This looks great, thanks for simplifying! I would also perhaps add a section on how to write tests using mock instruments.

Agreed (my reference to pyvisa-sim was intended to cover something similar)

@jenshnielsen jenshnielsen added this to the 0.25.0 milestone Apr 20, 2021
Copy link
Contributor

@astafan8 astafan8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that for now this is a good cleanup.

Shall the PR be renamed to "contribution guidelines: remove no longer relevant sections and make the sections on naming somewhat less strict" ? :)

CONTRIBUTING.rst Outdated Show resolved Hide resolved
CONTRIBUTING.rst Outdated Show resolved Hide resolved
Co-authored-by: Mikhail Astafev <astafan8@gmail.com>
@jenshnielsen jenshnielsen changed the title Update contributing guide contribution guidelines: remove no longer relevant sections and make the sections on naming somewhat less strict Apr 20, 2021
@jenshnielsen jenshnielsen merged commit be6ed96 into microsoft:master Apr 21, 2021
@jenshnielsen jenshnielsen deleted the update_contributing branch April 21, 2021 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants