AMI430 3D driver: allow instantiating from names of existing AMI430 instances, next to from AMI430 instances only #2949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…MI430 ... makes it possible to define AMI430_3D in station YAML configuration file
Codecov Report
@@ Coverage Diff @@
## master #2949 +/- ##
=======================================
Coverage 65.41% 65.42%
=======================================
Files 209 209
Lines 28122 28127 +5
=======================================
+ Hits 18397 18403 +6
+ Misses 9725 9724 -1 |
jenshnielsen
approved these changes
Apr 22, 2021
| mag_x.name, mag_y, badly_typed_instrument_z_argument, | ||
| field_limit | ||
| ) | ||
|
|
There was a problem hiding this comment.
Should we also add a test for a badly named instrument. E.g. a string but not the name of an AMI
There was a problem hiding this comment.
yes. i'll add a variation of the test_instantiation_from_name_of_nonexistent_instrument for that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful when defining AMI430_3D in station YAML config file (after defining the individual AMI430 axes)
as requested by @jdwatson.
also: Make error message explicit when instrument with name does not exist.