Make doNd reset original post_delay values + fix to keyboard interrupt #2996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2996 +/- ##
=======================================
Coverage 65.48% 65.49%
=======================================
Files 213 213
Lines 28391 28397 +6
=======================================
+ Hits 18592 18598 +6
Misses 9799 9799 |
jenshnielsen
approved these changes
May 12, 2021
astafan8
approved these changes
May 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doNd functions will currently modify post_delay values on swept parameters that will propagate outside of the doNd function. This will modify sweep rates of the parameter if post_delay/step values are used to limit sweep rates in qcodes.
Ideally this would also be added to the interrupt handle context but didnt include it there as I am not too familiar with python contexts.
Also moved dataset definition up to before the context starts as a keyboard interrupt throws an error due to dataset not being defined.
PR has been tested on offline computer but not actual measurements for now.