Ensure that plot dataset uses axis in the expected order #3017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3017 +/- ##
==========================================
- Coverage 65.49% 65.48% -0.01%
==========================================
Files 213 213
Lines 28397 28388 -9
==========================================
- Hits 18598 18590 -8
+ Misses 9799 9798 -1 |
astafan8
approved these changes
May 17, 2021
Co-authored-by: Mikhail Astafev <astafan8@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it was the code relied implicitly on the order of axis in the loaded data dictionary. This used to be stable since the data was alwasy loaded from the database in the order the columns was defined. However now the data may be loaded from the in memory cache the order is no longer guaranteed. This should fix the issue by relying on the order of axis defined by the interdeps object.
As a bonus this simplifies the code a bit by no longer having to pop the dependent data axis out and insert it again