Keysight VNA P9374A driver #3034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Module for the Keysight VNA. It relies on the classes of a different category of network analyzers but seems to work pretty well.
astafan8
approved these changes
May 20, 2021
There was a problem hiding this comment.
thanks for the contribution @RosenblumLabUser ! I clarified the PR description so that it looks more informative when we make a changelog :)
| nports=2, | ||
| **kwargs) | ||
|
|
||
| options = self.get_options() |
There was a problem hiding this comment.
is it really necessary to call this? the returned value is unused. or is there some useful side-effect of the get_options method?
Codecov Report
@@ Coverage Diff @@
## master #3034 +/- ##
=======================================
Coverage 65.51% 65.51%
=======================================
Files 213 214 +1
Lines 28492 28498 +6
=======================================
+ Hits 18667 18671 +4
- Misses 9825 9827 +2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Module for the Keysight VNA.
It relies on the classes of a different category of network analyzers but seems to work pretty well.
Fixes #issuenumber.
Changes proposed in this pull request:
@mention one core developer