Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade precommit hooks to latest version #3037

Merged
merged 4 commits into from
May 21, 2021

Conversation

jenshnielsen
Copy link
Collaborator

No description provided.

@jenshnielsen jenshnielsen force-pushed the upgrade_pre_commit_hooks branch 2 times, most recently from 5fb1f7d to 6140381 Compare May 20, 2021 15:01
@codecov
Copy link

codecov bot commented May 20, 2021

Codecov Report

Merging #3037 (ebd9d67) into master (0ab8a58) will decrease coverage by 0.01%.
The diff coverage is 68.80%.

@@            Coverage Diff             @@
##           master    #3037      +/-   ##
==========================================
- Coverage   65.55%   65.53%   -0.02%     
==========================================
  Files         213      213              
  Lines       28442    28442              
==========================================
- Hits        18645    18640       -5     
- Misses       9797     9802       +5     

astafan8
astafan8 previously approved these changes May 20, 2021
@jenshnielsen
Copy link
Collaborator Author

@astafan8 had to rerun pyupgrade so please rereview

@jenshnielsen jenshnielsen dismissed astafan8’s stale review May 20, 2021 15:28

significant changes since review

Copy link
Contributor

@astafan8 astafan8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I skimmed thorugh and did not see any problems with black/pyupgrade. however there might be merge conflicts when the many-yaml-station PR is merged, so i'd suggest we land that first and then land this PR

@astafan8 astafan8 disabled auto-merge May 20, 2021 16:26
@jenshnielsen jenshnielsen merged commit 83a65e3 into microsoft:master May 21, 2021
@jenshnielsen jenshnielsen deleted the upgrade_pre_commit_hooks branch May 21, 2021 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants