Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export complex numbers to netcdf #3126

Merged
merged 12 commits into from
Jun 15, 2021

Conversation

jenshnielsen
Copy link
Collaborator

@jenshnielsen jenshnielsen commented Jun 15, 2021

@jenshnielsen jenshnielsen mentioned this pull request Jun 15, 2021
1 task
@jenshnielsen
Copy link
Collaborator Author

One question remains. Should we completely drop the netcdf4 package and go with h5netcdf for all the export?

You can read about h5netcdf here https://pypi.org/project/h5netcdf/ and why the author anyway thinks its better than the netcdf4 python package

@astafan8
Copy link
Contributor

Should we completely drop the netcdf4 package

i think we should. i really don't like myself this situation with hdf5 being behind a netcdf interface that does not have full feature parity thus producing invalid netcdf (but valid hdf5), but - if there's one storage format/engine, then it's easier to maintain, right? and we must let users export data with complex numbers, no way around that. so i'm happy to use h5netcdf only.

@codecov
Copy link

codecov bot commented Jun 15, 2021

Codecov Report

Merging #3126 (65da543) into master (2a37d6e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3126   +/-   ##
=======================================
  Coverage   65.66%   65.67%           
=======================================
  Files         216      216           
  Lines       28765    28769    +4     
=======================================
+ Hits        18889    18893    +4     
  Misses       9876     9876           

@jenshnielsen
Copy link
Collaborator Author

This ended up requiring to bump the minimum versions of xarray and in turn numpy and pandas

@jenshnielsen jenshnielsen merged commit b755b9b into microsoft:master Jun 15, 2021
@jenshnielsen jenshnielsen deleted the netcdf_complex_data branch June 15, 2021 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants