-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export complex numbers to netcdf #3126
Export complex numbers to netcdf #3126
Conversation
jenshnielsen
commented
Jun 15, 2021
•
edited
edited
- Basic test that complex numbers can be exported
- Fix the issue see http://xarray.pydata.org/en/stable/howdoi.html
One question remains. Should we completely drop the netcdf4 package and go with h5netcdf for all the export? You can read about h5netcdf here https://pypi.org/project/h5netcdf/ and why the author anyway thinks its better than the netcdf4 python package |
i think we should. i really don't like myself this situation with hdf5 being behind a netcdf interface that does not have full feature parity thus producing invalid netcdf (but valid hdf5), but - if there's one storage format/engine, then it's easier to maintain, right? and we must let users export data with complex numbers, no way around that. so i'm happy to use h5netcdf only. |
Codecov Report
@@ Coverage Diff @@
## master #3126 +/- ##
=======================================
Coverage 65.66% 65.67%
=======================================
Files 216 216
Lines 28765 28769 +4
=======================================
+ Hits 18889 18893 +4
Misses 9876 9876 |
This ended up requiring to bump the minimum versions of xarray and in turn numpy and pandas |