Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix R&S ZNB setting npts in CW mode #3168

Merged
merged 2 commits into from
Jul 2, 2021

Conversation

mgunyho
Copy link
Contributor

@mgunyho mgunyho commented Jul 2, 2021

Fixes #3151.

I branched off of v0.26, let me know if you want me to rebase onto master.

@jenshnielsen

@codecov
Copy link

codecov bot commented Jul 2, 2021

Codecov Report

Merging #3168 (7c0ef60) into master (89f6020) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #3168      +/-   ##
==========================================
- Coverage   65.91%   65.91%   -0.01%     
==========================================
  Files         217      217              
  Lines       28902    28903       +1     
==========================================
  Hits        19051    19051              
- Misses       9851     9852       +1     

@jenshnielsen
Copy link
Collaborator

@mgunyho Thanks, We can merge master into this branch and then merge so that should be fine. The fix looks good to me. Did you test it on a real instrument ?

@mgunyho
Copy link
Contributor Author

mgunyho commented Jul 2, 2021

Yeah I tested with an instrument. Setting npts() in the example I had in the issue works now. I also quickly skimmed through the driver if the current sweep type should be checked elsewhere, looks like this is the only place.

@jenshnielsen jenshnielsen merged commit f5c4c42 into microsoft:master Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting R&S ZNB npts fails in CW mode
2 participants