Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabeling dond function to handle multiple datasets #3186

Merged
merged 42 commits into from
Aug 19, 2021

Conversation

FarBo
Copy link
Contributor

@FarBo FarBo commented Jul 8, 2021

This PR:

Enables dond to accept grouped measuerment parameters and callables and open a dataset for each group.
This implementation preserves the old way of comma-separated passing meaurements and callables in the function construct. If this is the case, all those arguments will be categorized in one group and one dataset will be created.

  • Improve the implementation
  • writing tests
  • UAT
  • Update doNd notebook

@FarBo FarBo changed the title Far bo/multiple ds [WIP] Enabeling dond function to handle multiple datasets Jul 8, 2021
@codecov
Copy link

codecov bot commented Jul 13, 2021

Codecov Report

Merging #3186 (4709279) into master (5c90cf4) will increase coverage by 0.07%.
The diff coverage is 98.86%.

@@            Coverage Diff             @@
##           master    #3186      +/-   ##
==========================================
+ Coverage   66.09%   66.16%   +0.07%     
==========================================
  Files         220      220              
  Lines       29150    29209      +59     
==========================================
+ Hits        19267    19327      +60     
+ Misses       9883     9882       -1     

@FarBo FarBo marked this pull request as ready for review July 13, 2021 11:10
@FarBo FarBo changed the title [WIP] Enabeling dond function to handle multiple datasets Enabeling dond function to handle multiple datasets Jul 14, 2021
@FarBo
Copy link
Contributor Author

FarBo commented Aug 14, 2021

@jenshnielsen
ATM, the code is broken because of this new params_meas_caller thing to handle the threading. I should modify the old implementation to adopt that. So if you are reviewing the code, please consider this.

@jenshnielsen
Copy link
Collaborator

@FarBo Yes I am aware. In the future please mark a pr a draft if you know it is broken

@FarBo FarBo changed the title Enabeling dond function to handle multiple datasets [WIP]Enabeling dond function to handle multiple datasets Aug 14, 2021
@FarBo FarBo changed the title [WIP]Enabeling dond function to handle multiple datasets Enabeling dond function to handle multiple datasets Aug 16, 2021
@jenshnielsen jenshnielsen merged commit 2a9f448 into microsoft:master Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants