Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use public interface for instrument in parameters #3187

Merged
merged 6 commits into from
Jul 8, 2021

Conversation

jenshnielsen
Copy link
Collaborator

  • Avoid setting instrument via private _instrument attribute but pass it to base class
  • Use public property as getter
  • Update example notebook to do the same

@codecov
Copy link

codecov bot commented Jul 8, 2021

Codecov Report

Merging #3187 (198de9b) into master (4c1e64c) will increase coverage by 0.00%.
The diff coverage is 24.13%.

@@           Coverage Diff           @@
##           master    #3187   +/-   ##
=======================================
  Coverage   65.92%   65.92%           
=======================================
  Files         218      218           
  Lines       28910    28902    -8     
=======================================
- Hits        19058    19055    -3     
+ Misses       9852     9847    -5     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants