-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default experiment in qcodes #3214
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3214 +/- ##
==========================================
+ Coverage 65.99% 66.03% +0.03%
==========================================
Files 218 219 +1
Lines 29009 29041 +32
==========================================
+ Hits 19145 19177 +32
Misses 9864 9864 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to spent some effort on reworking the imports. The sqlite modules should not import from the experiment container
26c5b34
to
34200db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@FarBo The code should now be ready please push your changes to the notebook and this should be good to go
Thanks @jenshnielsen for the final work on this. I will finish the notebook today and push it, then we can merge it afterward. |
79e1244
to
d899758
Compare
d899758
to
9457f24
Compare
This PR: