get_guids_from_multiple_run_ids accepts connection over dbpath in the function [breaking change] #3222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3222 +/- ##
==========================================
- Coverage 65.95% 65.94% -0.01%
==========================================
Files 218 218
Lines 28966 28960 -6
==========================================
- Hits 19104 19098 -6
Misses 9862 9862 |
|
This breaking change should be documented in the changelog. Will you start a new changelog for 0.28 ? |
|
I will start it after merging this PR |
jenshnielsen
approved these changes
Jul 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for releasing
qcodes.dataset.sqlite.queriesfrom importingconnectfunction insqlite.databasethat could potentially creates circular dependency.The test file also modified accordingly, with a minimal change in the test method.