Logging: explicitly set encoding for file handler #3327
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents issues where the broken pipe character (used for delimiting messages) cannot be written to the log file if the file has a different encoding. Reading the documentation it is not clear to which extend this may also be an issue for the stream handler used for the console logging. This writes to stderr. According to https://docs.python.org/3/library/sys.html#sys.stderr the encoding of stderr should be defined by local on oses other than windows so this probably works without issues on windows (but there are some limitations as noted in the stderr documentation) On most other platforms I would expect local encoding to be utf8 anyway.