Fix issues with uncertainties #3334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jenshnielsen
commented
Sep 6, 2021
•
jenshnielsen
commented
- Upgrade minimum version to 3.1.4. This is the first version that ships a python 2/3 universal binary. This should hopefully resolve issues in Bump qtpy from 1.10.0 to 1.11.0 #3332
- Move the import into the function that uses it so logging setup does not trigger an import of uncertainties
This is the first version to ship an universion 2/3 version It should fix issues with ur prefix seen in microsoft#3332
into function that uses it This prevents qcodes logging and conftest from importing in Triggering a warning at conf test time (from deprecated imp
astafan8
approved these changes
Sep 6, 2021
Codecov Report
@@ Coverage Diff @@
## master #3334 +/- ##
=======================================
Coverage 66.20% 66.20%
=======================================
Files 220 220
Lines 29250 29250
=======================================
Hits 19365 19365
Misses 9885 9885 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.