Tektronix AWG70000 add support for 70001B and 70002B #3438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now if a device says that it is 'AWG7000xB', this module can still work with it. The interaction protocol is the same for AWG70000A and AWG70000B. The module file is still called 'AWG70000A' to keep reverse compatibility.
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #3438 +/- ##
=======================================
Coverage 65.17% 65.17%
=======================================
Files 221 221
Lines 29839 29839
=======================================
Hits 19447 19447
Misses 10392 10392 |
|
Looks good to me @astafan8 are you happy to merge this? |
|
@aadiyatul Would it be ok to change the title to something like
That seems to me to more closely capture what it does |
aadiyatul
changed the title
jenshnielsen
approved these changes
Oct 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the code will also work if the device responds that it is AWG7000xB.
The communication protocols for both are the same. Tested on a real AWG70002B.
Module and class names not changed to keep the existing API.
@jenshnielsen