Create public api for dataset. #3536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenshnielsen
force-pushed
the
add_plot_to_dataset_api
branch
from
b597d96
to
bc0439b
Compare
Codecov Report
@@ Coverage Diff @@
## master #3536 +/- ##
==========================================
- Coverage 68.39% 68.39% -0.01%
==========================================
Files 232 235 +3
Lines 30872 30884 +12
==========================================
+ Hits 21115 21122 +7
- Misses 9757 9762 +5 |
jenshnielsen
force-pushed
the
add_plot_to_dataset_api
branch
from
bc0439b
to
e3a68af
Compare
jenshnielsen
force-pushed
the
add_plot_to_dataset_api
branch
3 times, most recently
from
bc0f9ab
to
bb6213f
Compare
astafan8
previously approved these changes
Jan 6, 2022
jenshnielsen
force-pushed
the
add_plot_to_dataset_api
branch
3 times, most recently
from
a505c2a
to
e89a5af
Compare
jenshnielsen
force-pushed
the
add_plot_to_dataset_api
branch
from
6451637
to
c222b1f
Compare
jenshnielsen
changed the title
|
Should probably rename the dond module to clarify the difference between the dond function and module |
jenshnielsen
force-pushed
the
add_plot_to_dataset_api
branch
3 times, most recently
from
2db5424
to
a501d56
Compare
astafan8
reviewed
Mar 14, 2022
jenshnielsen
force-pushed
the
add_plot_to_dataset_api
branch
2 times, most recently
from
6799651
to
786a902
Compare
jenshnielsen
commented
Jun 8, 2022
To hopefully break circular imports
jenshnielsen
force-pushed
the
add_plot_to_dataset_api
branch
from
1eba7dd
to
6e23eba
Compare
jenshnielsen
dismissed
astafan8’s stale review
Things have changed significantly since this review so lets review again
|
@astafan8 Could you have a look again. The description has been updated to reflect what is in scope and what is not |
astafan8
approved these changes
Jun 10, 2022
Co-authored-by: Mikhail Astafev <astafan8@gmail.com>
jenshnielsen
commented
Jun 10, 2022
jenshnielsen
force-pushed
the
add_plot_to_dataset_api
branch
from
59f4bd4
to
33c8143
Compare
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Jun 13, 2022
3536: Create public api for dataset. r=jenshnielsen a=jenshnielsen
* Move dond module to dataset where it belongs more naturally
* Let utils be a module that is independent of the rest of qcodes to avoid cirular dependenceis
1. Move Slack and schema installation to a new module extensions
2. Refactor a few other modules to import qcodes inside the functions. These will eventually be moved elsewhere
* Import and document all methods used in dataset examples at the level of qcodes.dataset.
* Add shims for old modules. These will not currently raise warnings. I suggest we turn these on after the new api is in a release to avoid confusion
This does not in general update examples to use the new imports. I suggest we do that after this pr has been merged. Can be done in small batches making review easier.
Co-authored-by: Jens H. Nielsen <Jens.Nielsen@microsoft.com>
Co-authored-by: Jens Hedegaard Nielsen <jenshnielsen@gmail.com>
|
This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried. Additional information: {"message":"All comments must be resolved.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not in general update examples to use the new imports. I suggest we do that after this pr has been merged. Can be done in small batches making review easier.