Use sleep instead of post_delay in doNd #3576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3576 +/- ##
=======================================
Coverage 65.69% 65.69%
=======================================
Files 225 225
Lines 30465 30465
=======================================
Hits 20014 20014
Misses 10451 10451 |
|
@jenshnielsen |
|
@FarBo Yes the sleep should be between set of setpoints and getting the parameter |
|
@FarBo I think this is close to being ready. Could you add a changelog entry? |
astafan8
approved these changes
Nov 16, 2021
for more information, see https://pre-commit.ci
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is created to change the delay time between setpoints in doNd functions. This is done because the current post_delay logic can unintentionally prolong the delay time if a ramped parameter is used, which the ramp time is shorter than the delay time provided in the doNd functions.
The PR is addressing this issue:
#3564