AMI430: Fix switch heater parameters that return 0 or 1 as a string #3650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astafan8
reviewed
Dec 6, 2021
Co-authored-by: Mikhail Astafev <astafan8@gmail.com>
peendebak
commented
Dec 9, 2021
peendebak
commented
Dec 9, 2021
and yaml config to match
Codecov Report
@@ Coverage Diff @@
## master #3650 +/- ##
==========================================
- Coverage 65.73% 65.72% -0.01%
==========================================
Files 226 226
Lines 30547 30547
==========================================
- Hits 20080 20078 -2
- Misses 10467 10469 +2 |
|
@peendebak I pushed a basic test and added support for enabling disabling the switch heater in the yaml simulator. I think this should be ready to merge now? |
astafan8
changed the title
|
🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
1 similar comment
|
🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
|
bors merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parameters from the AMI430 switch heater return a string such as
0\n. This was parsed by stripping and then casting to bool. Butbool('0')is True, which is not what the parameter should return.