Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Register InstrumentModules separately from ChannelLists #3834

Merged
merged 5 commits into from
Jan 19, 2022
Merged

Register InstrumentModules separately from ChannelLists #3834

merged 5 commits into from
Jan 19, 2022

Conversation

jenshnielsen
Copy link
Collaborator

@jenshnielsen jenshnielsen commented Jan 18, 2022 •
edited

  • Register channels and channel lists in two separate dicts. This is done on the basis of the ABC to avoid a circular import

Open questions

  • Deprecate submodules dict (yes but not now)
  • Adapt snapshot etc to use the channels rather than (again not now)
  • Better names for the new dicts (channels is not an option since many instruments uses that as the name of the channel list)

@codecov
Copy link

codecov bot commented Jan 18, 2022 •
edited

Codecov Report

Merging #3834 (e092e40) into master (0d1422e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3834   +/-   ##
=======================================
  Coverage   65.57%   65.58%           
=======================================
  Files         227      227           
  Lines       30643    30651    +8     
=======================================
+ Hits        20095    20103    +8     
  Misses      10548    10548

@astafan8 astafan8 added this to the 0.32.0 milestone Jan 18, 2022
@jenshnielsen jenshnielsen mentioned this pull request Jan 18, 2022
Merged
@jenshnielsen jenshnielsen force-pushed the channels_cleanup branch 2 times, most recently from f8b3864 to 919128b Compare January 19, 2022 12:59
@jenshnielsen jenshnielsen changed the title Submodule improvements Register InstrumentModules separately from ChannelLists Jan 19, 2022
@jenshnielsen
Copy link
Collaborator Author

Bors merge

@bors
Copy link
Contributor

bors bot commented Jan 19, 2022

Build succeeded:

@bors bors bot merged commit cb9ab07 into microsoft:master Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astafan8 astafan8 astafan8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.32.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jenshnielsen @astafan8