ChannelTuple/List correctly handle getting an attribute from an empty list #3856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenshnielsen
force-pushed
the
channel_list_get_attr
branch
from
b6368af
to
fe4031e
Compare
|
🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
Codecov Report
@@ Coverage Diff @@
## master #3856 +/- ##
=======================================
Coverage 65.77% 65.77%
=======================================
Files 228 228
Lines 31085 31089 +4
=======================================
+ Hits 20446 20450 +4
Misses 10639 10639 |
|
bors merge |
|
Canceled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will ensure that if you do a instr.channel.parameter you get an attribute error as expected and not an index error.
This also means that getattr etc will work as expected since it can catch the correct error.
Also refactor the getattr code a bit to split out a method for the multiparameter construction to keep the function at a resonable lenght.
This is done on top of #3851 which should be merged first.