Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metadata to netcdf file where the DataSet is exported to #3932

Merged
merged 14 commits into from
Feb 17, 2022
Merged

Add metadata to netcdf file where the DataSet is exported to #3932

merged 14 commits into from
Feb 17, 2022

Conversation

astafan8
Copy link
Contributor

@astafan8 astafan8 commented Feb 15, 2022 •
edited

Otherwise, adding metadata after the export happened will not propagate it to the exported netcdf file.

todo:

  • Make sure that the pull request contains a short description of the changes made.
  • Please include automatic tests for the changes made when possible.
  • Create a file in the docs\changes\newsfragments folder with a short description of the change 1234.improved

@astafan8 astafan8 added this to the 0.33.0 milestone Feb 15, 2022
@codecov
Copy link

codecov bot commented Feb 15, 2022 •
edited

Codecov Report

Merging #3932 (81e2fcb) into master (1669afe) will increase coverage by 0.02%.
The diff coverage is 97.29%.

@@            Coverage Diff             @@
##           master    #3932      +/-   ##
==========================================
+ Coverage   66.07%   66.10%   +0.02%     
==========================================
  Files         228      228              
  Lines       31160    31189      +29     
==========================================
+ Hits        20590    20618      +28     
- Misses      10570    10571       +1

@astafan8 astafan8 marked this pull request as ready for review February 16, 2022 12:00
@astafan8
extract xarray_to_h5netcdf_with_complex_numbers function
bce8a59
@astafan8
add _add_metadata_to_netcdf_if_nc_exported method to BaseDataSet
2d06c9b
@astafan8
Use _add_metadata_to_netcdf_if_nc_exported in add_metadata of DataSet
09f74fe
@astafan8
Use _add_metadata_to_netcdf_if_nc_exported in add_metadata of DataSet…
86e4570 
…InMem
@astafan8
Do not add export_info metadata to the exported nc file
ab036fb
@astafan8
open netcdf file with h5netcdf in "r+" mode for adding attributes
806f7f9
@astafan8
remove commented out unused xarray_to_h5netcdf_with_complex_numbers call
6937817
@astafan8
test that metadata added after export is propagated to the netcdf file
21585f7
@astafan8
add 3932.improved
97fa4a1
@astafan8
Make _set_export_info part of DataSetProtocol and implement it withou…
7b6e779 
…t explicit call to add_metadata
@astafan8
warn if adding metadata to netcdf file is not possible because it doe…
2257d48 
…s not exist
@astafan8
pytest.warns(UserWarning
e1305cf
@astafan8 astafan8 merged commit 08de530 into microsoft:master Feb 17, 2022
@jenshnielsen jenshnielsen deleted the metadatanetcdf branch February 17, 2022 10:29
@jenshnielsen jenshnielsen mentioned this pull request Feb 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenshnielsen jenshnielsen jenshnielsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.33.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@astafan8 @jenshnielsen