Fix loading of >1 dim netcdf datasets from netcdf to DataSetinmem #3945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astafan8
reviewed
Feb 21, 2022
jenshnielsen
commented
Feb 21, 2022
jenshnielsen
commented
Feb 21, 2022
jenshnielsen
commented
Feb 21, 2022
Codecov Report
@@ Coverage Diff @@
## master #3945 +/- ##
==========================================
+ Coverage 65.82% 65.83% +0.01%
==========================================
Files 228 228
Lines 31442 31464 +22
==========================================
+ Hits 20696 20714 +18
- Misses 10746 10750 +4 |
jenshnielsen
force-pushed
the
load_higher_dim_netcdf
branch
4 times, most recently
from
3a16e1a
to
e7405db
Compare
|
@astafan8 ready for a first review I think. Will add a newsfragment before merging |
jenshnielsen
force-pushed
the
load_higher_dim_netcdf
branch
from
5a43525
to
4dd8e7e
Compare
Co-authored-by: Mikhail Astafev <astafan8@gmail.com>
Co-authored-by: Mikhail Astafev <astafan8@gmail.com>
jenshnielsen
force-pushed
the
load_higher_dim_netcdf
branch
from
4dd8e7e
to
b5a7db3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wrong from of meshgrid was being used