Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split instrument module in Parameters and Instrument modules #3972

Merged
merged 28 commits into from
Jun 16, 2022
Merged

Split instrument module in Parameters and Instrument modules #3972

merged 28 commits into from
Jun 16, 2022

Conversation

jenshnielsen
Copy link
Collaborator

@jenshnielsen jenshnielsen commented Mar 1, 2022 •
edited

  • Update tests and internal use for the new modules.
  • Readd old modules for backwards compatibility
  • Ensure that instrument module contains the right imports
  • Ensure that parameters module contains the right imports
  • Renamed _BaseParameter to ParameterBase

Things to do after this pr merges

  • Reorganize new parameter modules better
  • Enable autodocsumm for the new modules

@jenshnielsen jenshnielsen changed the title declare functions and methods in qcodes.instrument as reexported declare functions and methods in qcodes.instrument and qcodes.config as reexported Mar 1, 2022
@codecov
Copy link

codecov bot commented Mar 1, 2022 •
edited

Codecov Report

Merging #3972 (32236e0) into master (fa7e07c) will decrease coverage by 0.04%.
The diff coverage is 93.58%.

@@            Coverage Diff             @@
##           master    #3972      +/-   ##
==========================================
- Coverage   68.39%   68.35%   -0.05%     
==========================================
  Files         235      241       +6     
  Lines       30887    30887              
==========================================
- Hits        21125    21112      -13     
- Misses       9762     9775      +13

@jenshnielsen jenshnielsen force-pushed the qcodes_instrument_public_interface branch from 7d96cb9 to 9102b37 Compare April 17, 2022 08:26
@astafan8 astafan8 added this to the 0.34.0 milestone Apr 26, 2022
@astafan8 astafan8 force-pushed the qcodes_instrument_public_interface branch from cacfda7 to 3f05dd9 Compare June 3, 2022 10:09
@jenshnielsen jenshnielsen force-pushed the qcodes_instrument_public_interface branch 3 times, most recently from 692be99 to bf4be03 Compare June 4, 2022 10:20
@jenshnielsen jenshnielsen changed the title declare functions and methods in qcodes.instrument and qcodes.config as reexported declare functions and methods in qcodes.instrument as reexported Jun 4, 2022
@jenshnielsen jenshnielsen force-pushed the qcodes_instrument_public_interface branch 8 times, most recently from 890a925 to 40e0a62 Compare June 13, 2022 11:32
@jenshnielsen jenshnielsen force-pushed the qcodes_instrument_public_interface branch from 73db6be to 4ea1698 Compare June 15, 2022 08:21
@jenshnielsen
Copy link
Collaborator Author

bors merge

@bors
Copy link
Contributor

bors bot commented Jun 16, 2022

Canceled.

@jenshnielsen
Copy link
Collaborator Author

bors merge

bors bot added a commit that referenced this pull request Jun 16, 2022
@bors @jenshnielsen
Merge #3972
46328b8 
3972: Split instrument module in Parameters and Instrument modules  r=jenshnielsen a=jenshnielsen

- [X] Update tests and internal use for the new modules. 
- [x] Readd old modules for backwards compatibility
- [x] Ensure that instrument module contains the right imports
- [x] Ensure that parameters module contains the right imports 
- [x] Renamed _BaseParameter to ParameterBase 

Things to do after this pr merges

- [ ] Reorganize new parameter modules better
- [ ] Enable autodocsumm for the new modules


Co-authored-by: Jens H. Nielsen <Jens.Nielsen@microsoft.com>
Co-authored-by: Jens Hedegaard Nielsen <jenshnielsen@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jun 16, 2022

Build failed:

@jenshnielsen
Copy link
Collaborator Author

Bors retry

@bors
Copy link
Contributor

bors bot commented Jun 16, 2022

Build succeeded:

@bors bors bot merged commit 0c36f04 into microsoft:master Jun 16, 2022
@jenshnielsen jenshnielsen deleted the qcodes_instrument_public_interface branch June 16, 2022 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trevormorgan trevormorgan trevormorgan approved these changes

@astafan8 astafan8 Awaiting requested review from astafan8

@Dominik-Vogel Dominik-Vogel Awaiting requested review from Dominik-Vogel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.35.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jenshnielsen @astafan8 @Dominik-Vogel @trevormorgan