Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #4080 resizing of hdf5 array #4081

Merged
merged 3 commits into from
Jun 3, 2022

Conversation

sldesnoo-Delft
Copy link
Contributor

Use flat array when selecting the new data for hdf5 array update to write to file.

Closes #4080

@codecov
Copy link

codecov bot commented Apr 7, 2022

Codecov Report

Merging #4081 (f34af76) into master (ce40759) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4081      +/-   ##
==========================================
- Coverage   67.02%   66.99%   -0.04%     
==========================================
  Files         233      233              
  Lines       31517    31517              
==========================================
- Hits        21124    21114      -10     
- Misses      10393    10403      +10     

Copy link
Contributor

@astafan8 astafan8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! would you be willing to add a test for this? could probably be just the code from the issue.

@astafan8
Copy link
Contributor

@sldesnoo-Delft would you be willing to add a test for this? could probably be just the code from the issue.

and could you also add a newsfragment (see here https://qcodes.github.io/Qcodes/community/contributing.html#pull-requests ) ?

@sldesnoo-Delft
Copy link
Contributor Author

@sldesnoo-Delft would you be willing to add a test for this? could probably be just the code from the issue.

and could you also add a newsfragment (see here https://qcodes.github.io/Qcodes/community/contributing.html#pull-requests ) ?

@astafan8, I definitely would like to do so. Unfortunately I'm very busy at the moment. Can I do so in a few weeks?

@astafan8
Copy link
Contributor

astafan8 commented May 3, 2022

@sldesnoo-Delft sure, no problem! perhaps you'll have time before ~mid May when we plan to make the next release?

@jenshnielsen
Copy link
Collaborator

bors merge

@bors
Copy link
Contributor

bors bot commented Jun 3, 2022

🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.

@bors bors bot merged commit 30f9701 into microsoft:master Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HDF5 error with 'slow' acquisition of 2D array
3 participants