-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed #4080 resizing of hdf5 array #4081
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4081 +/- ##
==========================================
- Coverage 67.02% 66.99% -0.04%
==========================================
Files 233 233
Lines 31517 31517
==========================================
- Hits 21124 21114 -10
- Misses 10393 10403 +10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! would you be willing to add a test for this? could probably be just the code from the issue.
@sldesnoo-Delft would you be willing to add a test for this? could probably be just the code from the issue. and could you also add a newsfragment (see here https://qcodes.github.io/Qcodes/community/contributing.html#pull-requests ) ? |
@astafan8, I definitely would like to do so. Unfortunately I'm very busy at the moment. Can I do so in a few weeks? |
@sldesnoo-Delft sure, no problem! perhaps you'll have time before ~mid May when we plan to make the next release? |
bors merge |
🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
Use flat array when selecting the new data for hdf5 array update to write to file.
Closes #4080