Add db/phase sweep for rohde_schwarz ZNB driver #4139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astafan8
reviewed
Apr 26, 2022
There was a problem hiding this comment.
looks great, thank you!
could you add a newsfragment file as explained here https://qcodes.github.io/Qcodes/community/contributing.html#pull-requests (see last bullet point in pull requests section) ?
|
Done ^^ |
|
🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
|
👎 Rejected by PR status |
Codecov Report
@@ Coverage Diff @@
## master #4139 +/- ##
==========================================
- Coverage 66.06% 66.04% -0.02%
==========================================
Files 233 233
Lines 31483 31498 +15
==========================================
+ Hits 20799 20803 +4
- Misses 10684 10695 +11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
I simply added a sweep class to return the magnitude in db when doing a magnitude/phase sweep.
Hopes everything is good.