Let instrument names be less restrictive. #4257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenshnielsen
force-pushed
the
validate_full_name
branch
from
814b27d
to
01f92f6
Compare
Codecov Report
@@ Coverage Diff @@
## master #4257 +/- ##
==========================================
- Coverage 68.39% 67.44% -0.95%
==========================================
Files 235 235
Lines 30884 30887 +3
==========================================
- Hits 21122 20832 -290
- Misses 9762 10055 +293 |
A property mock reuses the return value so let name_parts make a copy
jenshnielsen
force-pushed
the
validate_full_name
branch
from
3a37d9a
to
e7f15b0
Compare
astafan8
approved these changes
Jun 14, 2022
jenshnielsen
added a commit
that referenced
this pull request
Jun 14, 2022
Let instrument names be less restrictive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow submodules that are not them self valid identifiers provided that full name is.