API: Split internal instrument.base.py module #4283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To be merged after #4281 to not create a conflict |
jenshnielsen
commented
Jun 17, 2022
Codecov Report
@@ Coverage Diff @@
## master #4283 +/- ##
==========================================
+ Coverage 68.40% 68.41% +0.01%
==========================================
Files 251 253 +2
Lines 30948 30962 +14
==========================================
+ Hits 21169 21183 +14
Misses 9779 9779 |
jenshnielsen
force-pushed
the
api/update_interal_instruments
branch
from
46a0c9c
to
9d2613c
Compare
jenshnielsen
commented
Jun 17, 2022
jenshnielsen
force-pushed
the
api/update_interal_instruments
branch
from
b45dccf
to
b7fb215
Compare
jenshnielsen
commented
Jun 20, 2022
jenshnielsen
commented
Jun 20, 2022
jenshnielsen
force-pushed
the
api/update_interal_instruments
branch
from
b7fb215
to
5fd7fe9
Compare
astafan8
approved these changes
Jun 21, 2022
Co-authored-by: Mikhail Astafev <astafan8@gmail.com>
jenshnielsen
force-pushed
the
api/update_interal_instruments
branch
from
e89da5b
to
633d50a
Compare
|
bors merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split base into instruument.py and instrument_base.py
This matches how the parameters module now does it and has the advantage that