-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve logging in doNd #4288
Improve logging in doNd #4288
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4288 +/- ##
=======================================
Coverage 68.40% 68.40%
=======================================
Files 251 251
Lines 30948 30951 +3
=======================================
+ Hits 21169 21172 +3
Misses 9779 9779 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors merge
4288: Improve logging in doNd r=astafan8 a=jenshnielsen Makes it easier to understand how parameters are unpacked and should be measured Include 2 other small fixes to the module * Use a mapping over dict to clarify that input is not modified * rename an internal variable for clarity Co-authored-by: Jens H. Nielsen <Jens.Nielsen@microsoft.com> Co-authored-by: Jens Hedegaard Nielsen <jenshnielsen@gmail.com>
Canceled. |
bors merge |
4288: Improve logging in doNd r=jenshnielsen a=jenshnielsen Makes it easier to understand how parameters are unpacked and should be measured Include 2 other small fixes to the module * Use a mapping over dict to clarify that input is not modified * rename an internal variable for clarity Co-authored-by: Jens H. Nielsen <Jens.Nielsen@microsoft.com> Co-authored-by: Jens Hedegaard Nielsen <jenshnielsen@gmail.com>
This PR was included in a batch that successfully built, but then failed to merge into master (it was a non-fast-forward update). It will be automatically retried. |
Merge conflict. |
This clarifies that this contains non parameters and matches measured_parameters
bors merge |
🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
Makes it easier to understand how parameters are unpacked and should be measured
Include 2 other small fixes to the module