Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ChannelTuple: add ability to call regular callable #4292

Merged
merged 5 commits into from
Jul 26, 2022
Merged

ChannelTuple: add ability to call regular callable #4292

merged 5 commits into from
Jul 26, 2022

Conversation

jenshnielsen
Copy link
Collaborator

@jenshnielsen jenshnielsen commented Jun 20, 2022 •
edited

This IMHO eliminates the only important feature Functions has over a regular method on a InstrumentModule/Channel

TODO

  • Add a changelog entry

@jenshnielsen jenshnielsen marked this pull request as draft June 20, 2022 12:32
@jenshnielsen jenshnielsen mentioned this pull request Jun 20, 2022
Merged
astafan8
astafan8 reviewed Jun 20, 2022
View reviewed changes
Copy link
Contributor

@astafan8 astafan8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, this should do :)

@codecov
Copy link

codecov bot commented Jul 25, 2022 •
edited

Codecov Report

Merging #4292 (e9028bc) into master (82d4567) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #4292   +/-   ##
=======================================
  Coverage   68.35%   68.36%           
=======================================
  Files         276      276           
  Lines       31023    31029    +6     
=======================================
+ Hits        21207    21213    +6     
  Misses       9816     9816

@jenshnielsen jenshnielsen changed the title [WIP] ChannelTuple: add ability to call regular callable ChannelTuple: add ability to call regular callable Jul 25, 2022
@jenshnielsen jenshnielsen marked this pull request as ready for review July 25, 2022 19:44
astafan8
astafan8 approved these changes Jul 26, 2022
View reviewed changes
Copy link
Contributor

@astafan8 astafan8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! :)

qcodes/tests/test_channels.py Outdated Show resolved Hide resolved
@jenshnielsen @astafan8
remove comment
e9028bc 
Co-authored-by: Mikhail Astafev <astafan8@gmail.com>
@jenshnielsen
Copy link
Collaborator Author

bors merge

@bors
Copy link
Contributor

bors bot commented Jul 26, 2022

Build succeeded:

@bors bors bot merged commit 9d27254 into microsoft:master Jul 26, 2022
@jenshnielsen jenshnielsen deleted the channeltuple_call_method branch July 26, 2022 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astafan8 astafan8 astafan8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jenshnielsen @astafan8