API: refactor threading and make public #4348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jenshnielsen
commented
Jul 4, 2022
jenshnielsen
commented
- Split into parts requiring dataset and move there
- Make other reused parts public at utils level.
- Make parts documented in examples public at ds level
Move ds specific classes and functions to ds and make public when needed
Codecov Report
@@ Coverage Diff @@
## master #4348 +/- ##
==========================================
- Coverage 68.37% 68.37% -0.01%
==========================================
Files 267 269 +2
Lines 30961 30967 +6
==========================================
+ Hits 21170 21174 +4
- Misses 9791 9793 +2 |
jenshnielsen
changed the title
astafan8
approved these changes
Jul 4, 2022
|
bors merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.