Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: Make numpy utils public #4349

Merged
merged 1 commit into from
Jul 4, 2022
Merged

API: Make numpy utils public #4349

merged 1 commit into from
Jul 4, 2022

Conversation

jenshnielsen
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Jul 4, 2022 •
edited

Codecov Report

Merging #4349 (1334fbd) into master (c4983cd) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4349      +/-   ##
==========================================
- Coverage   68.37%   68.37%   -0.01%     
==========================================
  Files         267      267              
  Lines       30961    30959       -2     
==========================================
- Hits        21170    21168       -2     
  Misses       9791     9791

@jenshnielsen jenshnielsen changed the title API Make numpy utils public API: Make numpy utils public Jul 4, 2022
Dominik-Vogel
Dominik-Vogel approved these changes Jul 4, 2022
View reviewed changes
Copy link
Contributor

@Dominik-Vogel Dominik-Vogel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am surprised by what is all public API (like deprecate). I am really happy that you are driving this process to clean things up.

@jenshnielsen
Copy link
Collaborator Author

I am surprised by what is all public API (like deprecate). I am really happy that you are driving this process to clean things up.

My guiding lines what that if QCoDeS should be truely modular then each module should only use the public API of other modules. We are not fully there yet

@jenshnielsen
Copy link
Collaborator Author

bors merge

@bors
Copy link
Contributor

bors bot commented Jul 4, 2022

Build succeeded:

@bors bors bot merged commit 95c1deb into microsoft:master Jul 4, 2022
@jenshnielsen jenshnielsen deleted the api/numpy_utils branch July 4, 2022 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astafan8 astafan8 astafan8 approved these changes

@Dominik-Vogel Dominik-Vogel Dominik-Vogel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jenshnielsen @astafan8 @Dominik-Vogel