Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate setuptools pep621 config to pyproject.toml #4382

Merged
merged 7 commits into from
Jul 21, 2022

Conversation

jenshnielsen
Copy link
Collaborator

@jenshnielsen jenshnielsen commented Jul 11, 2022

This moves the supported and non experimental
parts of setuptools config to pyproject.toml
These are the parts standardized by pep621 and
supported in setuptools >=65

These are the supported parts of #4049

@jenshnielsen jenshnielsen marked this pull request as draft July 11, 2022 09:30
@codecov
Copy link

codecov bot commented Jul 11, 2022

Codecov Report

Merging #4382 (a776df5) into master (ad35f92) will decrease coverage by 0.94%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4382      +/-   ##
==========================================
- Coverage   68.35%   67.41%   -0.95%     
==========================================
  Files         275      275              
  Lines       31021    31021              
==========================================
- Hits        21205    20912     -293     
- Misses       9816    10109     +293     

@jenshnielsen jenshnielsen marked this pull request as ready for review July 21, 2022 09:41
@jenshnielsen
Copy link
Collaborator Author

@astafan8 I think this is ready for review if we are ok to use my fork of requirements-buider until support is merged upstream

Copy link
Contributor

@astafan8 astafan8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's go for it! on the flaming edge of the python tech :)

setup.cfg Show resolved Hide resolved
.github/workflows/pytest-min-versions.yaml Show resolved Hide resolved
setup.py Show resolved Hide resolved
setup.py Show resolved Hide resolved
setup.cfg Show resolved Hide resolved
This moves the supported and non experimental
parts of setuptools config to pyproject.toml
These are the parts standadized by pep621 and
supported in setuptools 65 onwards
@jenshnielsen jenshnielsen merged commit 8ceeb5c into microsoft:master Jul 21, 2022
@jenshnielsen jenshnielsen deleted the build/setuptoolspep621 branch July 21, 2022 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants