-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Give InstrumentBase a label that can be nicely formatted #4460
Give InstrumentBase a label that can be nicely formatted #4460
Conversation
The order of the arguments in the Please point me to any other parts of code that need to be changed accordingly (if any). |
Codecov Report
@@ Coverage Diff @@
## master #4460 +/- ##
==========================================
+ Coverage 68.00% 68.03% +0.03%
==========================================
Files 299 290 -9
Lines 31440 31323 -117
==========================================
- Hits 21381 21311 -70
+ Misses 10059 10012 -47 |
According to codecov, the coverage in the file instrument_drivers/AlazarTech/ATS.py drops. I'm not sure why. Otherwise, the checks seem to pass. |
@klkl0808 You can safely disregard that. There is a bug in codecov where it sometimes does not merge all the coverage from the different runners correctly (this test only runs on windows) |
I agree that this order is less ideal but I am not comfortable changing it I think this should also work for Did you think about if there is a need for something like full name for the label? E.g. such that you can merge the label of a channel and the instrument? |
Done.
Good point. I think it makes sense, because the user could use the label in conjunction with the parent instrument name or standalone. So it would be good to have two versions of labels. From a user perspective, it would make sense to set the label like Since the idea of the label is to have a nice format, maybe it would be best to leave this up to the user. My suggestion would be to give each |
Co-authored-by: Mikhail Astafev <astafan8@gmail.com>
968a4ed
to
c77d137
Compare
@klkl0808 Thanks, I think its fair that we wait with figuring out if merging needs to happen later |
Add a label to InstrumentBase that can store a nicely-formatted instrument name. The implementation is similar to the label in Parameter. Previously discussed here.
docstrings, an example notebook or restructured text files.