Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the parameter auto_freq_ref to N51x1 Keysight signal generators class #4472

Merged
merged 7 commits into from
Aug 4, 2022
Merged

Added the parameter auto_freq_ref to N51x1 Keysight signal generators class #4472

merged 7 commits into from
Aug 4, 2022

Conversation

bguttel
Copy link
Contributor

@bguttel bguttel commented Aug 4, 2022

No description provided.

bguttel and others added 3 commits August 4, 2022 10:42
@bguttel
Update N51x1.py
9218e88 
Added the option to set `auto_freq_ref`. From the Keysight manual:
This command enables or disables the ability of the signal generator to
automatically select between the internal and an external reference oscillator.
@bguttel
Merge branch 'QCoDeS:master' into master
05402e3
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
f2e690c 
for more information, see https://pre-commit.ci
@codecov
Copy link

codecov bot commented Aug 4, 2022 •
edited

Codecov Report

Merging #4472 (aa62556) into master (0bf7214) will decrease coverage by 0.98%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master    #4472      +/-   ##
==========================================
- Coverage   68.03%   67.04%   -0.99%     
==========================================
  Files         292      292              
  Lines       31318    31270      -48     
==========================================
- Hits        21306    20964     -342     
- Misses      10012    10306     +294

@bguttel
Update N51x1.py
1c031a6 
Use the function `create_on_off_val_mapping`
@jenshnielsen
Copy link
Collaborator

Thanks @bguttel Would you mind creating a 4472.improved_driver file here explaining the change so it can be added to the changelog.

@bguttel
Copy link
Contributor Author

bguttel commented Aug 4, 2022

@jenshnielsen Done.
Let me know if you think more details are required..

@jenshnielsen
Copy link
Collaborator

@bguttel Thanks, We use darker to gradually make new code conform to the standard defined by black so I just ran the formatter on the new code with darker -r master qcodes and committed that. The pr should be ready to merge now

@jenshnielsen jenshnielsen merged commit d10493d into microsoft:master Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenshnielsen jenshnielsen jenshnielsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bguttel @jenshnielsen