Avoid recursion for bytes / bytearrays in json encoder #4621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astafan8
approved these changes
Sep 15, 2022
Codecov Report
@@ Coverage Diff @@
## master #4621 +/- ##
==========================================
- Coverage 68.23% 67.30% -0.94%
==========================================
Files 339 339
Lines 31799 31799
==========================================
- Hits 21698 21402 -296
- Misses 10101 10397 +296 |
jenshnielsen
force-pushed
the
json_bytes
branch
from
6b36466
to
03e3c1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4620
Note that this does not in any way attempt to support bytes that cannot be converted to a string but at least these will not trigger an infinite recursion.