Remove deprecated import of loop etc at the top level of qcodes #4674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jenshnielsen
commented
Sep 30, 2022
•
jenshnielsen
commented
- Needs a breaking change note
Codecov Report
@@ Coverage Diff @@
## master #4674 +/- ##
==========================================
- Coverage 68.25% 68.24% -0.01%
==========================================
Files 339 339
Lines 31981 31981
==========================================
- Hits 21829 21826 -3
- Misses 10152 10155 +3 |
astafan8
approved these changes
Oct 3, 2022
jenshnielsen
force-pushed
the
remove_deprecated_imports
branch
from
d9dc981
to
5fabade
Compare
Co-authored-by: Mikhail Astafev <astafan8@gmail.com>
jenshnielsen
force-pushed
the
remove_deprecated_imports
branch
from
5fabade
to
008663c
Compare
|
bors merge |
|
👎 Rejected by PR status |
|
bors merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.