-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add random sample to guid #4763
Add random sample to guid #4763
Conversation
resolves #4504 |
15aae2c
to
dd11b13
Compare
Codecov Report
@@ Coverage Diff @@
## master #4763 +/- ##
==========================================
- Coverage 68.20% 67.28% -0.93%
==========================================
Files 339 339
Lines 32003 32016 +13
==========================================
- Hits 21828 21541 -287
- Misses 10175 10475 +300 |
af03ce6
to
efb6349
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to the open question: i agree, it might not be worth the effort to have 3 options, my hope is that due to lack of advertizing not many users used the guid customization.
7b5b349
to
851e736
Compare
851e736
to
43f1eb9
Compare
Todo
|
fb36146
to
5fc91a2
Compare
@astafan8 should be ready for a real review |
The current time resolution, especially on windows, is insufficient to ensure that we always avoid collisions in guids. Since sample names are available within the dataset metadata and the sample part of the guid is cumbersome to use I suggest that we replace that with a random string.
The broad plan is
For now we ami to completely remove the support of setting a sample_id. If actual use shows up we are open to allow this to be enabled as an explicit option