Stop using __file__ outside tests #4797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astafan8
approved these changes
Nov 9, 2022
jenshnielsen
force-pushed
the
use_imporlib_resources
branch
from
14c4c8f
to
f3de894
Compare
Co-authored-by: Mikhail Astafev <astafan8@gmail.com>
jenshnielsen
force-pushed
the
use_imporlib_resources
branch
from
f3de894
to
52b94de
Compare
Codecov Report
@@ Coverage Diff @@
## master #4797 +/- ##
==========================================
- Coverage 68.14% 68.14% -0.01%
==========================================
Files 341 341
Lines 29845 29853 +8
==========================================
+ Hits 20339 20344 +5
- Misses 9506 9509 +3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the remaining use of
__file__withfilesfromimporlib.resourcesin qcodes outside of the tests.Note that there is a trade off here as we now have hardcoded the path to config and monitor dist files in the python file rather than the relative path to that file. I think its cleaner to hardcode the full path but I could see the argument the other way around too.