Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the option to set pulse modulation in the Keysight N51x1 signal generators #4840

Merged
merged 5 commits into from
Nov 30, 2022

Conversation

bguttel
Copy link
Contributor

@bguttel bguttel commented Nov 29, 2022

Notice that there are two parameters there, one that sets the general state of the pulse modulation (boolean) and one that sets whether it will be 'internal' or 'external'.

Not all the signal generators come with this feature so I added an if condition to test for it.

@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Merging #4840 (8f3685f) into master (0556305) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #4840      +/-   ##
==========================================
- Coverage   68.30%   68.29%   -0.01%     
==========================================
  Files         339      339              
  Lines       32123    32126       +3     
==========================================
  Hits        21942    21942              
- Misses      10181    10184       +3     

@jenshnielsen
Copy link
Collaborator

@bguttel Thanks, looks good. Could you create a file at /docs/changes/news_fragments/4840.improved_driver with a short description of the fix so it makes it into the changelog

Documentation of the pulse modulation parameters
@bguttel
Copy link
Contributor Author

bguttel commented Nov 30, 2022

@bguttel Thanks, looks good. Could you create a file at /docs/changes/news_fragments/4840.improved_driver with a short description of the fix so it makes it into the changelog

Added the file.
@jenshnielsen let me know if there is anything more that you think I should add! :)

@jenshnielsen jenshnielsen merged commit ecd9f5a into microsoft:master Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants