Fix: DelegateParameter.validate also validates the source parameter #4870
Conversation
Prior to this change, DelegateParameter.validate only uses its own validator, ignoring the source parameter. This change adds an extra layer of validation by using the source parameter's validator in DelegateParameter.validate.
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #4870 +/- ##
==========================================
- Coverage 68.31% 67.41% -0.91%
==========================================
Files 340 340
Lines 32236 32240 +4
==========================================
- Hits 22022 21733 -289
- Misses 10214 10507 +293 |
Prior to this change, it was missing a test when Parameter or DelegateParameter has offset and scale This change adds a test to verify that .validate ignores the offset and scale
Prior to this change, DelegateParameter.validate only uses its own validator, ignoring the source parameter. This change adds an extra layer of validation by using the source parameter's validator in DelegateParameter.validate.
for more information, see https://pre-commit.ci
Prior to this change, it was missing a test when Parameter or DelegateParameter has offset and scale This change adds a test to verify that .validate ignores the offset and scale
jenshnielsen
force-pushed
the
hotfix/DelegateParamValueValidation
branch
from
f364667
to
2ac5285
Compare
|
@Junliang-Wang Thanks, Could you add a small description of the change in docs/changes/newsfragments/4870.improved |
Sure, although I have a technical question: my local branch is now behind the master, I suppose that I should pull for the updates, and then commit the file in docs/changes/newsfragments/4870.improved, right? If I do so, I see that there is no 4870.improved, but rather 4876.improved. Should I create 4870.improved and write my changes? |
@Junliang-Wang "Should I create 4870.improved and write my changes" - yes :) these change-files are written PER pull-request, so don't add information to the existing ones :) So, the 4876.improved file that you see was written for PR number 4876, and the one you're about to write is for 4870 because the PR you have open has number 4870. |
|
@astafan8 Thanks for the answer! I have pushed your suggestion, along with 4870.improved file. |
Prior to this change, DelegateParameter.validate only uses its own validator, ignoring the source parameter.
This change adds an extra layer of validation by using the source parameter's validator in DelegateParameter.validate.
These changes are related to the discussion #4819