Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make it a no op to mark a run completed twice #4876

Merged

Conversation

jenshnielsen
Copy link
Collaborator

Otherwise one may very easily trigger an unintentional change of the time stamp

@jenshnielsen jenshnielsen force-pushed the make_marking_completed_twice_no_op branch from ff98a98 to ac73b8c Compare December 20, 2022 08:42
@jenshnielsen jenshnielsen marked this pull request as draft December 20, 2022 08:42
@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Merging #4876 (3f78c23) into master (3f78c23) will not change coverage.
The diff coverage is n/a.

❗ Current head 3f78c23 differs from pull request most recent head 4839f91. Consider uploading reports for the commit 4839f91 to get more accurate results

@@           Coverage Diff           @@
##           master    #4876   +/-   ##
=======================================
  Coverage   68.31%   68.31%           
=======================================
  Files         340      340           
  Lines       32150    32150           
=======================================
  Hits        21964    21964           
  Misses      10186    10186           

@jenshnielsen jenshnielsen force-pushed the make_marking_completed_twice_no_op branch 2 times, most recently from 8f0fc22 to 82d6432 Compare December 20, 2022 11:04
@jenshnielsen jenshnielsen force-pushed the make_marking_completed_twice_no_op branch 2 times, most recently from 0cdf9a0 to c77feab Compare December 20, 2022 11:09
@jenshnielsen jenshnielsen marked this pull request as ready for review December 20, 2022 11:11
@jenshnielsen jenshnielsen force-pushed the make_marking_completed_twice_no_op branch from c77feab to 4839f91 Compare December 20, 2022 12:52
@jenshnielsen jenshnielsen merged commit 30c585c into microsoft:master Dec 20, 2022
jenshnielsen added a commit that referenced this pull request Dec 20, 2022
…ce_no_op

make it a no op to mark a run completed twice
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants