Update scale transformation in pyqtgraph plot #4886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4886 +/- ##
==========================================
- Coverage 68.35% 68.31% -0.04%
==========================================
Files 340 340
Lines 32154 32155 +1
==========================================
- Hits 21978 21968 -10
- Misses 10176 10187 +11 |
|
@peendebak Thanks, could you add a newsfragment describing this fix |
Done. Would be nice if there is a github action to add such a fragment easily (cpython has this for example, although not for towncrier) |
jenshnielsen
force-pushed
the
fix_pyqtgraph_plot
branch
from
82ac85b
to
5f67131
Compare
|
I agree that it would be nice to streamline that a bit but I don't have the time to make such an improvement right now |
jenshnielsen
approved these changes
Jan 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the scale transformation in qcodes.plots.pyqtgraph to use the modern interface. I think the old interface was deprecated a very long time ago (see commnent in pyqtgraph/pyqtgraph#1533).
Fixes #4756. @rsokolewicz Could you check this PR with the quantify plotting?
@jenshnielsen