Check pyright in CI #4938
Merged
Check pyright in CI #4938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4938 +/- ##
=======================================
Coverage 68.79% 68.79%
=======================================
Files 352 352
Lines 32122 32130 +8
=======================================
+ Hits 22098 22104 +6
- Misses 10024 10026 +2 |
jenshnielsen
force-pushed
the
pyright_check
branch
from
1d14469
to
cc76107
Compare
jenshnielsen
force-pushed
the
pyright_check
branch
from
cc76107
to
f72ee45
Compare
astafan8
approved these changes
Jan 23, 2023
There was a problem hiding this comment.
shall this be mentioned in the contributing page in the docs https://qcodes.github.io/Qcodes/community/contributing.html#required-checks ?
|
bors merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix one last remaining type checking issue too