Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate qcodes.data plot loops actions and measure #4971

Merged
merged 31 commits into from
Feb 9, 2023

Conversation

jenshnielsen
Copy link
Collaborator

@jenshnielsen jenshnielsen commented Feb 3, 2023

This code now lives in https://github.com/qcodes/qcodes_loop with the first version being just published

TODO

  • Document breaking changes
  • Review that all compatibility imports are wrapped correctly in try except
  • Add links to loop repo and docs to readme
  • Add a qcodes[loop] extra dependency to pyproject.toml
  • Review and perhaps deprecate remaining use of loop within qcodes (mainly keithley driver)

@codecov
Copy link

codecov bot commented Feb 3, 2023

Codecov Report

Merging #4971 (305863f) into master (406e910) will decrease coverage by 1.56%.
The diff coverage is 13.45%.

@@            Coverage Diff             @@
##           master    #4971      +/-   ##
==========================================
- Coverage   68.75%   67.19%   -1.56%     
==========================================
  Files         356      356              
  Lines       32153    29725    -2428     
==========================================
- Hits        22106    19975    -2131     
+ Misses      10047     9750     -297     

README.rst Show resolved Hide resolved
docs/changes/newsfragments/4971.breaking Outdated Show resolved Hide resolved
docs/changes/newsfragments/4971.breaking Outdated Show resolved Hide resolved
docs/changes/newsfragments/4971.breaking Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@jenshnielsen jenshnielsen force-pushed the remove_loop branch 2 times, most recently from 24d0d6e to d05d674 Compare February 7, 2023 09:32
@jenshnielsen jenshnielsen added this pull request to the merge queue Feb 9, 2023
@jenshnielsen jenshnielsen removed this pull request from the merge queue due to a manual request Feb 9, 2023
@jenshnielsen jenshnielsen added this pull request to the merge queue Feb 9, 2023
@jenshnielsen jenshnielsen removed this pull request from the merge queue due to a manual request Feb 9, 2023
@jenshnielsen jenshnielsen added this pull request to the merge queue Feb 9, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 9, 2023
@jenshnielsen jenshnielsen added this pull request to the merge queue Feb 9, 2023
Merged via the queue into microsoft:master with commit 83da2f1 Feb 9, 2023
@jenshnielsen jenshnielsen deleted the remove_loop branch February 9, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants