Dataset: change default guid type to use a random str #5031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenshnielsen
force-pushed
the
dataset/change_default_guid
branch
from
9c30d3d
to
eede0fb
Compare
|
test_update_existing_guids is failing since its reading back a sample_id and then trying to generate a new sample with that id. And since its now an error to do that it will raise |
Codecov Report
@@ Coverage Diff @@
## master #5031 +/- ##
=======================================
Coverage 67.31% 67.31%
=======================================
Files 357 357
Lines 29840 29846 +6
=======================================
+ Hits 20086 20092 +6
Misses 9754 9754 |
jenshnielsen
force-pushed
the
dataset/change_default_guid
branch
from
983f662
to
c61244f
Compare
trevormorgan
approved these changes
Feb 27, 2023
This was referenced Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As earlier suggested this switches the default to replace sample by a random string eliminating duplicate guids. That was especially likely if generating lots of guids on the same system rapidly after each other on a system with low time resolution