Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add driver for Lakeshore Model 335 #5043

Merged
merged 29 commits into from
Mar 6, 2023

Conversation

jbeckerwsi
Copy link
Contributor

@jbeckerwsi jbeckerwsi commented Mar 1, 2023

  • Add driver for Lakeshore Model 335
  • Increase range on setpoint property of Lakeshore Model 335,336,372 to support degree Celsius

@jbeckerwsi
Copy link
Contributor Author

Pending test on hardware

@jbeckerwsi jbeckerwsi marked this pull request as draft March 1, 2023 14:11
@jbeckerwsi jbeckerwsi changed the title Add driver for Lakeshore335 add driver for Lakeshore335 Mar 1, 2023
@jbeckerwsi jbeckerwsi changed the title add driver for Lakeshore335 add driver for Lakeshore Model 335 Mar 1, 2023
@codecov
Copy link

codecov bot commented Mar 2, 2023

Codecov Report

Merging #5043 (96d8400) into master (520c56e) will increase coverage by 0.03%.
The diff coverage is 93.18%.

@@            Coverage Diff             @@
##           master    #5043      +/-   ##
==========================================
+ Coverage   67.32%   67.35%   +0.03%     
==========================================
  Files         357      358       +1     
  Lines       29845    29886      +41     
==========================================
+ Hits        20093    20131      +38     
- Misses       9752     9755       +3     

@jbeckerwsi jbeckerwsi marked this pull request as ready for review March 2, 2023 14:31
@jenshnielsen jenshnielsen added this pull request to the merge queue Mar 6, 2023
Merged via the queue into microsoft:master with commit dc7f063 Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants